fix: random zones only when zones are not provided #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ericyz force-pushed the fix/read-zones branch 9 times, most recently from 6a16a8f to bd576af Compare 
| /gcbrun |
1 similar comment
| /gcbrun |
| /gcbrun |
1 similar comment
| /gcbrun |
ericyz force-pushed the fix/read-zones branch 3 times, most recently from 5675931 to 6487b2c Compare | /gcbrun |
1 similar comment
| /gcbrun |
ericyz force-pushed the fix/read-zones branch 4 times, most recently from 6322000 to 65b85c2 Compare | /gcbrun |
bharathkkb approved these changes Aug 22, 2023
There was a problem hiding this comment.
Thanks for the PR @ericyz. A minor comment about the ACM change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Solves #1442