Skip to content

Conversation

cread
Copy link
Contributor

@cread cread commented Jul 17, 2023

Closes #1588

@cread cread requested review from a team, Jberlinsky and ericyz as code owners July 17, 2023 21:37
@cread cread changed the title Add support for optionally specifying disk_size and disk_type for cluster_autoscaling feat: Add support for disk_size and disk_type for cluster_autoscaling. Jul 18, 2023
@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

auto_repair = bool
auto_upgrade = bool
disk_size = optional(number)
disk_type = optional(string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using optional, could you also update min TF version to >= 1.3


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@bharathkkb bharathkkb changed the title feat: Add support for disk_size and disk_type for cluster_autoscaling. feat!: Add support for disk_size and disk_type for cluster_autoscaling. Jul 26, 2023
@bharathkkb
Copy link
Member

/gcbrun

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@bharathkkb bharathkkb merged commit fd233e5 into terraform-google-modules:master Jul 28, 2023
@cread cread deleted the add-cluster-autoscaling-disk-support branch July 28, 2023 19:30
@cread
Copy link
Contributor Author

cread commented Aug 30, 2023

Any idea when 28.0.0 will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants