Skip to content

Commit 3dc4df2

Browse files
yjbanovyjbanov
committed
chore(analysis): analyze web folders; fix existing warnings
1 parent f830cfc commit 3dc4df2

File tree

17 files changed

+40
-165
lines changed

17 files changed

+40
-165
lines changed

‎modules/angular2/src/facade/collection.dart‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,11 @@ class ListWrapper {
154154
static List slice(List l, int from, int to) {
155155
return l.sublist(from, to);
156156
}
157+
static List splice(List l, int from, int to) {
158+
var sub = l.sublist(from, to);
159+
l.removeRange(from, to);
160+
return sub;
161+
}
157162
static void sort(List l, compareFn(a,b)) {
158163
l.sort(compareFn);
159164
}

‎modules/angular2/src/facade/collection.es6‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,9 @@ export class ListWrapper {
193193
static slice(l:List, from:int, to:int):List {
194194
return l.slice(from, to);
195195
}
196+
static splice(l:List, from:int, to:int):List {
197+
return l.splice(from, to);
198+
}
196199
static sort(l:List, compareFn:Function) {
197200
l.sort(compareFn);
198201
}

‎modules/benchmarks/src/change_detection/change_detection_benchmark.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection';
21
import {reflector} from 'angular2/src/reflection/reflection';
32
import {isPresent, isJsObject} from 'angular2/src/facade/lang';
43
import {getIntParameter, bindAction, microBenchmark} from 'angular2/src/test_lib/benchmark_util';

‎modules/benchmarks/src/compiler/compiler_benchmark.js‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
import {DOM} from 'angular2/src/dom/dom_adapter';
22
import {BrowserDomAdapter} from 'angular2/src/dom/browser_adapter';
3-
import {isBlank, Type} from 'angular2/src/facade/lang';
3+
import {Type} from 'angular2/src/facade/lang';
44
import {document} from 'angular2/src/facade/browser';
5-
import {MapWrapper} from 'angular2/src/facade/collection';
6-
import {DirectiveMetadata} from 'angular2/src/core/compiler/directive_metadata';
75
import {NativeShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/native_shadow_dom_strategy';
86

9-
import {Parser, Lexer, ProtoRecordRange, DynamicChangeDetection} from 'angular2/change_detection';
7+
import {Parser, Lexer, DynamicChangeDetection} from 'angular2/change_detection';
108

119
import {Compiler, CompilerCache} from 'angular2/src/core/compiler/compiler';
1210
import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader';
@@ -25,7 +23,6 @@ import {ReflectionCapabilities} from 'angular2/src/reflection/reflection_capabil
2523
import {getIntParameter, bindAction} from 'angular2/src/test_lib/benchmark_util';
2624

2725
import {ProtoViewFactory} from 'angular2/src/core/compiler/proto_view_factory';
28-
import {Renderer} from 'angular2/src/render/api';
2926
import {DirectDomRenderer} from 'angular2/src/render/dom/direct_dom_renderer';
3027
import * as rc from 'angular2/src/render/dom/compiler/compiler';
3128

‎modules/benchmarks/src/largetable/largetable_benchmark.js‎

Lines changed: 5 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,24 @@
1-
import {Parser, Lexer, ChangeDetector, ChangeDetection, jitChangeDetection}
2-
from 'angular2/change_detection';
3-
import {ExceptionHandler} from 'angular2/src/core/exception_handler';
4-
5-
import {bootstrap, Component, Viewport, View, ViewContainer, Compiler, NgElement, Decorator} from 'angular2/angular2';
6-
7-
import {CompilerCache} from 'angular2/src/core/compiler/compiler';
8-
import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader';
9-
import {TemplateLoader} from 'angular2/src/render/dom/compiler/template_loader';
10-
import {TemplateResolver} from 'angular2/src/core/compiler/template_resolver';
11-
import {ShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/shadow_dom_strategy';
12-
import {NativeShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/native_shadow_dom_strategy';
13-
import {EmulatedUnscopedShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/emulated_unscoped_shadow_dom_strategy';
1+
import {bootstrap, Component, View} from 'angular2/angular2';
2+
143
import {LifeCycle} from 'angular2/src/core/life_cycle/life_cycle';
15-
import {UrlResolver} from 'angular2/src/services/url_resolver';
16-
import {StyleUrlResolver} from 'angular2/src/render/dom/shadow_dom/style_url_resolver';
17-
import {ComponentUrlMapper} from 'angular2/src/core/compiler/component_url_mapper';
18-
import {StyleInliner} from 'angular2/src/render/dom/shadow_dom/style_inliner';
19-
import {DynamicComponentLoader} from 'angular2/src/core/compiler/dynamic_component_loader';
20-
import {TestabilityRegistry, Testability} from 'angular2/src/core/testability/testability';
214

225
import {reflector} from 'angular2/src/reflection/reflection';
236
import {ReflectionCapabilities} from 'angular2/src/reflection/reflection_capabilities';
247
import {DOM} from 'angular2/src/dom/dom_adapter';
25-
import {isPresent, BaseException} from 'angular2/src/facade/lang';
268
import {window, document, gc} from 'angular2/src/facade/browser';
279
import {getIntParameter, getStringParameter, bindAction} from 'angular2/src/test_lib/benchmark_util';
2810

29-
import {XHR} from 'angular2/src/services/xhr';
30-
import {XHRImpl} from 'angular2/src/services/xhr_impl';
31-
32-
import {If, For, Switch, SwitchWhen, SwitchDefault} from 'angular2/directives';
11+
import {For, Switch, SwitchWhen, SwitchDefault} from 'angular2/directives';
3312
import {BrowserDomAdapter} from 'angular2/src/dom/browser_adapter';
3413

35-
import {EventManager} from 'angular2/src/render/dom/events/event_manager';
36-
3714
import {ListWrapper} from 'angular2/src/facade/collection';
38-
import {Parent} from 'angular2/src/core/annotations/visibility';
39-
40-
import {ViewFactory, VIEW_POOL_CAPACITY} from 'angular2/src/core/compiler/view_factory';
41-
import {ProtoViewFactory} from 'angular2/src/core/compiler/proto_view_factory';
42-
import {Renderer} from 'angular2/src/render/api';
43-
import {DirectDomRenderer} from 'angular2/src/render/dom/direct_dom_renderer';
44-
import * as rc from 'angular2/src/render/dom/compiler/compiler';
45-
import * as rvf from 'angular2/src/render/dom/view/view_factory';
15+
4616
import {Inject, bind} from 'angular2/di';
4717

4818
export const BENCHMARK_TYPE = 'LargetableComponent.benchmarkType';
4919
export const LARGETABLE_ROWS = 'LargetableComponent.rows';
5020
export const LARGETABLE_COLS = 'LargetableComponent.cols';
21+
5122
function _createBindings() {
5223
return [
5324
bind(BENCHMARK_TYPE).toValue(getStringParameter('benchmarkType')),
@@ -86,7 +57,6 @@ export function main() {
8657
var app;
8758
var lifecycle;
8859
var baselineRootLargetableComponent;
89-
var count = 0;
9060

9161
function ng2DestroyDom() {
9262
// TODO: We need an initial value as otherwise the getter for data.value will fail

‎modules/benchmarks/src/naive_infinite_scroll/app.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import {int, isPresent} from 'angular2/src/facade/lang';
2-
import {reflector} from 'angular2/src/reflection/reflection';
32
import {getIntParameter, bindAction} from 'angular2/src/test_lib/benchmark_util';
4-
import {bootstrap, Component, Viewport, View, ViewContainer, Compiler}
5-
from 'angular2/angular2';
3+
import {Component, View} from 'angular2/angular2';
64
import {PromiseWrapper} from 'angular2/src/facade/async';
75
import {ListWrapper} from 'angular2/src/facade/collection';
86
import {ScrollAreaComponent} from './scroll_area';

‎modules/benchmarks/src/naive_infinite_scroll/cells.js‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
1-
import {int} from 'angular2/src/facade/lang';
2-
import {reflector} from 'angular2/src/reflection/reflection';
3-
import {getIntParameter, bindAction} from 'angular2/src/test_lib/benchmark_util';
4-
import {bootstrap, Component, Viewport, View, ViewContainer, Compiler}
5-
from 'angular2/angular2';
6-
import {PromiseWrapper} from 'angular2/src/facade/async';
1+
import {Component, View} from 'angular2/angular2';
72
import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection';
83
import {Company, Opportunity, Offering, Account, CustomDate, STATUS_LIST}
94
from './common';

‎modules/benchmarks/src/naive_infinite_scroll/common.js‎

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import {int} from 'angular2/src/facade/lang';
21
import {Math} from 'angular2/src/facade/math';
32

4-
import {PromiseWrapper} from 'angular2/src/facade/async';
53
import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection';
64

75
export var ITEMS = 1000;
@@ -46,17 +44,17 @@ export var AAT_STATUS_LIST = [
4644

4745
// Just a non-trivial object. Nothing fancy or correct.
4846
export class CustomDate {
49-
year: int;
50-
month: int;
51-
day: int;
47+
year:number;
48+
month:number;
49+
day:number;
5250

53-
constructor(y:int, m:int, d:int) {
51+
constructor(y:number, m:number, d:number) {
5452
this.year = y;
5553
this.month = m;
5654
this.day = d;
5755
}
5856

59-
addDays(days:int):CustomDate {
57+
addDays(days:number):CustomDate {
6058
var newDay = this.day + days;
6159
var newMonth = this.month + Math.floor(newDay / 30);
6260
newDay = newDay % 30;
@@ -154,13 +152,13 @@ export class Offering extends RawEntity {
154152
this.set('account', val);
155153
}
156154

157-
get basePoints():int { return this.get('basePoints'); }
158-
set basePoints(val:int) {
155+
get basePoints():number { return this.get('basePoints'); }
156+
set basePoints(val:number) {
159157
this.set('basePoints', val);
160158
}
161159

162-
get kickerPoints():int { return this.get('kickerPoints'); }
163-
set kickerPoints(val:int) {
160+
get kickerPoints():number { return this.get('kickerPoints'); }
161+
set kickerPoints(val:number) {
164162
this.set('kickerPoints', val);
165163
}
166164

@@ -198,8 +196,8 @@ export class Opportunity extends RawEntity {
198196
}
199197

200198
export class Account extends RawEntity {
201-
get accountId():int { return this.get('accountId'); }
202-
set accountId(val:int) {
199+
get accountId():number { return this.get('accountId'); }
200+
set accountId(val:number) {
203201
this.set('accountId', val);
204202
}
205203
}

‎modules/benchmarks/src/naive_infinite_scroll/index.js‎

Lines changed: 3 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,13 @@
1-
import {int, isBlank} from 'angular2/src/facade/lang';
2-
import {DOM} from 'angular2/src/dom/dom_adapter';
31
import {MapWrapper} from 'angular2/src/facade/collection';
42

5-
import {Parser, Lexer, ChangeDetector, ChangeDetection}
6-
from 'angular2/change_detection';
7-
import {ExceptionHandler} from 'angular2/src/core/exception_handler';
8-
import {
9-
bootstrap, Component, Viewport, View, ViewContainer, Compiler, onChange, NgElement, Decorator
10-
} from 'angular2/angular2';
3+
import {bootstrap} from 'angular2/angular2';
114
import {reflector} from 'angular2/src/reflection/reflection';
125
import {ReflectionCapabilities} from 'angular2/src/reflection/reflection_capabilities';
13-
import {CompilerCache} from 'angular2/src/core/compiler/compiler';
14-
import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader';
15-
import {ShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/shadow_dom_strategy';
16-
import {NativeShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/native_shadow_dom_strategy';
17-
import {EmulatedUnscopedShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/emulated_unscoped_shadow_dom_strategy';
18-
import {TemplateLoader} from 'angular2/src/render/dom/compiler/template_loader';
19-
import {TemplateResolver} from 'angular2/src/core/compiler/template_resolver';
20-
import {LifeCycle} from 'angular2/src/core/life_cycle/life_cycle';
21-
import {XHR} from 'angular2/src/services/xhr';
22-
import {XHRImpl} from 'angular2/src/services/xhr_impl';
23-
import {UrlResolver} from 'angular2/src/services/url_resolver';
24-
import {StyleUrlResolver} from 'angular2/src/render/dom/shadow_dom/style_url_resolver';
25-
import {ComponentUrlMapper} from 'angular2/src/core/compiler/component_url_mapper';
26-
import {StyleInliner} from 'angular2/src/render/dom/shadow_dom/style_inliner';
27-
import {DynamicComponentLoader} from 'angular2/src/core/compiler/dynamic_component_loader';
28-
import {TestabilityRegistry, Testability} from 'angular2/src/core/testability/testability';
296

30-
import {If, For} from 'angular2/directives';
317
import {App} from './app';
32-
import {ScrollAreaComponent} from './scroll_area';
33-
import {ScrollItemComponent} from './scroll_item';
34-
import {CompanyNameComponent, OpportunityNameComponent, OfferingNameComponent,
35-
AccountCellComponent, StageButtonsComponent, FormattedCellComponent}
36-
from './cells';
378

38-
import {EventManager} from 'angular2/src/render/dom/events/event_manager';
39-
import {ViewFactory, VIEW_POOL_CAPACITY} from 'angular2/src/core/compiler/view_factory';
40-
import {ProtoViewFactory} from 'angular2/src/core/compiler/proto_view_factory';
41-
import {Renderer} from 'angular2/src/render/api';
42-
import {DirectDomRenderer} from 'angular2/src/render/dom/direct_dom_renderer';
43-
import * as rc from 'angular2/src/render/dom/compiler/compiler';
44-
import * as rvf from 'angular2/src/render/dom/view/view_factory';
45-
import {Inject, bind} from 'angular2/di';
9+
import {VIEW_POOL_CAPACITY} from 'angular2/src/core/compiler/view_factory';
10+
import {bind} from 'angular2/di';
4611

4712
export function main() {
4813
setupReflector();
@@ -59,7 +24,6 @@ export function setupReflector() {
5924
// TODO(kegluneq): Generate this.
6025
reflector.registerSetters({
6126
'style': (o, m) => {
62-
//if (isBlank(m)) return;
6327
// HACK
6428
MapWrapper.forEach(m, function(v, k) {
6529
o.style.setProperty(k, v);

‎modules/benchmarks/src/naive_infinite_scroll/scroll_area.js‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
1-
import {int, FINAL} from 'angular2/src/facade/lang';
2-
import {reflector} from 'angular2/src/reflection/reflection';
3-
import {getIntParameter, bindAction} from 'angular2/src/test_lib/benchmark_util';
4-
import {Component, Viewport, View, ViewContainer, Compiler}
5-
from 'angular2/angular2';
6-
import {PromiseWrapper} from 'angular2/src/facade/async';
1+
import {Component, View} from 'angular2/angular2';
72
import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection';
8-
import {DOM} from 'angular2/src/dom/dom_adapter';
93
import {Math} from 'angular2/src/facade/math';
104

115
import {Offering, ITEMS, ITEM_HEIGHT, VISIBLE_ITEMS, VIEW_PORT_HEIGHT,

0 commit comments

Comments
 (0)