Enable warnings as errors in CI (#842)

Motivation: Now that strict concurrency has been adopted the AHC should avoid regressing by treating all warnings as errors in CI. Modifications: - Treat warnings as errors in CI Result: Stricter CI

Author: glbrntt

.github/workflows/main.yml

@@ -12,11 +12,11 @@ jobs:
  uses: apple/swift-nio/.github/workflows/unit_tests.yml@main
  with:
  linux_5_9_enabled: false
- linux_5_10_arguments_override: "--explicit-target-dependency-import-check error"
- linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
- linux_6_1_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
- linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
- linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
+ linux_5_10_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -warnings-as-errors"
+ linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -warnings-as-errors"
+ linux_6_1_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -warnings-as-errors"
+ linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error"
+ linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error"
 
  static-sdk:
  name: Static SDK

.github/workflows/pull_request.yml

@@ -15,11 +15,11 @@ jobs:
  uses: apple/swift-nio/.github/workflows/unit_tests.yml@main
  with:
  linux_5_9_enabled: false
- linux_5_10_arguments_override: "--explicit-target-dependency-import-check error"
- linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
- linux_6_1_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
- linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
- linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
+ linux_5_10_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -warnings-as-errors"
+ linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -warnings-as-errors"
+ linux_6_1_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -warnings-as-errors"
+ linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error"
+ linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error"
 
  cxx-interop:
  name: Cxx interop

Sources/AsyncHTTPClient/HTTPClient.swift

@@ -338,6 +338,7 @@ public class HTTPClient {
  }
  }
 
+ @Sendable
  private func makeOrGetFileIOThreadPool() -> NIOThreadPool {
  self.fileIOThreadPoolLock.withLock {
  guard let fileIOThreadPool = self.fileIOThreadPool else {

Tests/AsyncHTTPClientTests/HTTPClientTestUtils.swift

@@ -287,7 +287,7 @@ enum TemporaryFileHelpers {
  shortEnoughPath = path
  restoreSavedCWD = false
  } catch SocketAddressError.unixDomainSocketPathTooLong {
- FileManager.default.changeCurrentDirectoryPath(
+ _ = FileManager.default.changeCurrentDirectoryPath(
  URL(fileURLWithPath: path).deletingLastPathComponent().absoluteString
  )
  shortEnoughPath = URL(fileURLWithPath: path).lastPathComponent
@@ -301,7 +301,7 @@ enum TemporaryFileHelpers {
  try? FileManager.default.removeItem(atPath: path)
  }
  if restoreSavedCWD {
- FileManager.default.changeCurrentDirectoryPath(saveCurrentDirectory)
+ _ = FileManager.default.changeCurrentDirectoryPath(saveCurrentDirectory)
  }
  }
  return try body(shortEnoughPath)