Skip to content

Conversation

@Rich-Harris
Copy link
Member

small tweak: we can make text-only fragments (like {#if true}hello!{/if}) more efficient by creating the text node directly, rather than cloning a fragment. Also the sequence.length === 1 special case isn't really doing anything for us, so we can simplify the code a bit

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 2dd0901

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

Rich-Harris commented Aug 15, 2024

Added a second optimisation:

<p>{location.href}</p>
-var root = $.template(`<p> </p>`); +var root = $.template(`<p></p>`); export default function Main($$anchor) { var p = root(); - var text = $.child(p); - text.nodeValue = location.href; - $.reset(p); + p.textContent = `${location.href ?? ""}`; $.append($$anchor, p); }
@Rich-Harris Rich-Harris merged commit d421838 into main Aug 15, 2024
@Rich-Harris Rich-Harris deleted the better-text-fragments branch August 15, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants