assert_equal: fix clippy::default_numeric_fallback #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #932 +/- ## ========================================== + Coverage 94.38% 94.53% +0.14% ========================================== Files 48 48 Lines 6665 6947 +282 ========================================== + Hits 6291 6567 +276 - Misses 374 380 +6 ☔ View full report in Codecov by Sentry. |
Type of `i` defaults to `i32` when `usize` should be used. It's only a problem if this function is called with two iterators longer than `i32::MAX`. It seems unlikely to me but who knows? `i32` should not be the default integer type in the library. `usize` would have more sense so I add the lint as warning (for the library only, it's okay in tests and benchmarks).
Philippe-Cholet force-pushed the clippy/default_numeric_fallback branch from 6adeee1 to fa94ba1 Compare Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Type of
idefaults toi32whenusizeshould be used.It's only a problem if this function is called with two iterators longer than
i32::MAX. It seems unlikely to me but who knows?i32should not be the default integer type in the library.usizewould have more sense so I add the lint as warning (for the library only, it's okay in tests and benchmarks).See lint doc: https://rust-lang.github.io/rust-clippy/master/index.html#/default_numeric_fallback