Case 0 and 1 of k_smallest and variants #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The iterator can have side effects so I think it should be consumed in all cases, even k=0. If there are no side-effect then maybe the compiler will optimize it away.
Like with `tail(1)`, I think we should leverage a possible faster specialization.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #909 +/- ## ========================================== - Coverage 94.38% 94.29% -0.10% ========================================== Files 48 48 Lines 6665 6815 +150 ========================================== + Hits 6291 6426 +135 - Misses 374 389 +15 ☔ View full report in Codecov by Sentry. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #904.
About the case
k=0, I wonder if all our iterators behave well on iterators with side-effects. I think we should update the specialization tests.