Loosen Fn
bounds to FnMut
#886
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In #885, I relaxed the
Fn
bounds toFnMut
for the new variants ofk_smallest
.It lead me to find out this is also possible for
diff_with
andItertools::into_group_map_by
.I'm not sure why we would need
Fn
bounds in our crate.clippy does not have a
disallowed_traits
lint or I would have addedFn
to it.