Skip to content

Change redismod docker to redis-stack-server #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 19, 2023
Merged

Change redismod docker to redis-stack-server #2556

merged 5 commits into from
Jan 19, 2023

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 19, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.
@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Jan 19, 2023
@dvora-h dvora-h requested a review from a team January 19, 2023 10:52
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023 •
edited
Loading

Codecov Report

Base: 92.27% // Head: 92.25% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (66baef0) compared to base (8592cac).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@ Coverage Diff @@ ## master #2556 +/- ## ========================================== - Coverage 92.27% 92.25% -0.03%  ========================================== Files 115 115 Lines 29613 29613 ========================================== - Hits 27325 27319 -6  - Misses 2288 2294 +6
Impacted Files Coverage Δ
redis/asyncio/cluster.py 91.68% <0.00%> (-0.33%) ⬇️
tests/test_asyncio/test_cluster.py 97.48% <0.00%> (-0.13%) ⬇️
tests/test_cluster.py 96.84% <0.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
@dvora-h dvora-h merged commit 18560b4 into redis:master Jan 19, 2023
@dvora-h dvora-h deleted the redis-stack branch June 18, 2023 00:36
zach-iee pushed a commit to sendbird/redis-py that referenced this pull request Aug 24, 2023
@dvora-h @chayim @zach-iee
Change redismod docker to redis-stack-server (redis#2556)
4f4f027 
* Change redismod docker to redis-stack-server * redis-stack-server * syntax * Update tox.ini * fetching docker from redis repo Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
zach-iee added a commit to sendbird/redis-py that referenced this pull request Aug 24, 2023
@zach-iee @dvora-h @chayim
Change redismod docker to redis-stack-server (redis#2556) (#12)
1856a34 
* Change redismod docker to redis-stack-server * redis-stack-server * syntax * Update tox.ini * fetching docker from redis repo Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

5 participants

@dvora-h @codecov-commenter @shacharPash @vladvildanov @chayim