Skip to content

Conversation

@DvirDukhan
Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Added dialect option to aggregate command

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Base: 92.23% // Head: 92.22% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0c782d4) compared to base (f10c81a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2537 +/- ## ========================================== - Coverage 92.23% 92.22% -0.02%  ========================================== Files 113 113 Lines 29380 29388 +8 ========================================== + Hits 27098 27102 +4  - Misses 2282 2286 +4 
Impacted Files Coverage Δ
redis/commands/search/aggregation.py 79.72% <100.00%> (+0.85%) ⬆️
tests/test_asyncio/test_search.py 98.63% <100.00%> (+<0.01%) ⬆️
tests/test_search.py 99.16% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 96.79% <0.00%> (-0.34%) ⬇️
tests/conftest.py 85.71% <0.00%> (+0.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h added the feature New feature label Jan 2, 2023
@dvora-h dvora-h merged commit ed38e77 into redis:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

3 participants