Skip to content

Conversation

@mohsinhaider
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Updates docstring for _disconnect_raise to correctly reflect code

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2022

Codecov Report

Base: 92.23% // Head: 92.21% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (cc92f06) compared to base (ed38e77).
Patch has no changes to coverable lines.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2534 +/- ## ========================================== - Coverage 92.23% 92.21% -0.02%  ========================================== Files 113 113 Lines 29388 29388 ========================================== - Hits 27106 27101 -5  - Misses 2282 2287 +5 
Impacted Files Coverage Δ
redis/asyncio/client.py 92.51% <ø> (ø)
tests/test_cluster.py 96.79% <0.00%> (-0.23%) ⬇️
tests/test_asyncio/test_cluster.py 97.48% <0.00%> (-0.13%) ⬇️
tests/test_asyncio/test_pubsub.py 99.53% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Jan 5, 2023
@dvora-h dvora-h merged commit a947728 into redis:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

3 participants