Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Dec 26, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes #2524

@dvora-h dvora-h added the bug Bug label Dec 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Base: 92.24% // Head: 92.20% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (073f7b6) compared to base (74c251a).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2531 +/- ## ========================================== - Coverage 92.24% 92.20% -0.04%  ========================================== Files 113 113 Lines 29357 29384 +27 ========================================== + Hits 27079 27094 +15  - Misses 2278 2290 +12 
Impacted Files Coverage Δ
redis/commands/graph/edge.py 95.83% <50.00%> (-2.00%) ⬇️
redis/commands/graph/node.py 95.74% <50.00%> (-2.04%) ⬇️
redis/commands/graph/path.py 78.57% <50.00%> (-1.06%) ⬇️
tests/test_cluster.py 96.79% <0.00%> (-0.34%) ⬇️
tests/test_asyncio/test_pubsub.py 99.37% <0.00%> (-0.16%) ⬇️
tests/test_asyncio/test_cluster.py 97.48% <0.00%> (-0.13%) ⬇️
tests/test_scripting.py 93.58% <0.00%> (-0.09%) ⬇️
tests/test_json.py 100.00% <0.00%> (ø)
redis/asyncio/sentinel.py 87.57% <0.00%> (ø)
redis/commands/cluster.py 94.02% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h requested a review from chayim December 26, 2022 11:16
@dvora-h dvora-h merged commit c7600b4 into redis:master Jan 8, 2023
@dvora-h dvora-h deleted the graph-eq branch June 18, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug

3 participants