Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Dec 25, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2525

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Dec 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2022

Codecov Report

Base: 92.24% // Head: 92.21% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (57c4dc5) compared to base (74c251a).
Patch coverage: 94.73% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2530 +/- ## ========================================== - Coverage 92.24% 92.21% -0.03%  ========================================== Files 113 113 Lines 29357 29375 +18 ========================================== + Hits 27079 27088 +9  - Misses 2278 2287 +9 
Impacted Files Coverage Δ
redis/asyncio/client.py 92.51% <0.00%> (ø)
redis/asyncio/connection.py 86.44% <100.00%> (-0.13%) ⬇️
redis/asyncio/lock.py 99.13% <100.00%> (ø)
tests/test_asyncio/test_connection_pool.py 99.40% <100.00%> (ø)
tests/test_asyncio/test_lock.py 100.00% <100.00%> (ø)
tests/test_asyncio/test_pubsub.py 99.53% <100.00%> (ø)
tests/test_cluster.py 96.79% <0.00%> (-0.34%) ⬇️
tests/test_asyncio/test_cluster.py 97.48% <0.00%> (-0.13%) ⬇️
tests/test_json.py 100.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h merged commit e67d15c into redis:master Jan 5, 2023
@dvora-h dvora-h deleted the get-loop branch June 18, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

3 participants