Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Nov 20, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

In the current implementation - if longitude or latitude are 0 b"FROMLONLAT", kwargs["longitude"], kwargs["latitude"]] will not be added and that will cause an error

Fixes #2462

@dvora-h dvora-h added the bug Bug label Nov 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

Base: 92.20% // Head: 92.21% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (8ad5c87) compared to base (dfe2152).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2464 +/- ## ========================================== + Coverage 92.20% 92.21% +0.01%  ========================================== Files 113 113 Lines 29239 29239 ========================================== + Hits 26960 26963 +3  + Misses 2279 2276 -3 
Impacted Files Coverage Δ
redis/commands/core.py 82.06% <100.00%> (ø)
tests/test_asyncio/test_search.py 98.26% <0.00%> (-0.35%) ⬇️
tests/test_cluster.py 96.97% <0.00%> (+0.11%) ⬆️
redis/asyncio/connection.py 86.57% <0.00%> (+0.12%) ⬆️
tests/test_asyncio/test_cluster.py 97.49% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h requested a review from chayim November 20, 2022 14:28
@chayim chayim changed the title Fix bug - Wrong number of arguments for geosearch command Wrong number of arguments for geosearch command Dec 1, 2022
@chayim chayim merged commit f4d07dd into redis:master Dec 1, 2022
@dvora-h dvora-h deleted the fix-geosearch-bug branch June 18, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug

3 participants