Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 14, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Aug 14, 2022
@dvora-h dvora-h requested a review from chayim August 14, 2022 08:22
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #2335 (776170f) into master (2cea637) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## master #2335 +/- ## ========================================== - Coverage 92.21% 92.20% -0.02%  ========================================== Files 111 111 Lines 28751 28751 ========================================== - Hits 26513 26509 -4  - Misses 2238 2242 +4 
Impacted Files Coverage Δ
tests/test_asyncio/test_bloom.py 99.57% <100.00%> (ø)
tests/test_asyncio/test_graph.py 99.22% <100.00%> (ø)
tests/test_bloom.py 99.60% <100.00%> (ø)
tests/test_graph.py 91.56% <100.00%> (ø)
tests/conftest.py 84.94% <0.00%> (-0.78%) ⬇️
tests/test_cluster.py 96.96% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h changed the title Fix GRAPH.LIST test Fix GRAPH.LIST & TDIGEST.QUANTILE tests Aug 14, 2022
@dvora-h dvora-h merged commit 29f80a5 into redis:master Aug 14, 2022
dvora-h added a commit that referenced this pull request Nov 21, 2022
* fix graph list_keys test * async test * fix tdigest.quantile * fix
@dvora-h dvora-h deleted the graph-test branch June 18, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

3 participants