Skip to content

Conversation

@psrok1
Copy link
Contributor

@psrok1 psrok1 commented Jun 23, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested? Documentation was built and checked if note appear correctly
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file? Change applies only to the documentation

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Added note in documentation on client_setname command. It applies only to the current connection and in some cases client_name argument should be used instead.

closes #2245

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #2247 (3f32b74) into master (6da8086) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #2247 +/- ## ======================================= Coverage 91.85% 91.85% ======================================= Files 108 108 Lines 27776 27776 ======================================= Hits 25515 25515 Misses 2261 2261 
Impacted Files Coverage Δ
redis/commands/core.py 82.11% <ø> (ø)
tests/test_cluster.py 96.95% <0.00%> (-0.12%) ⬇️
tests/conftest.py 87.25% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da8086...3f32b74. Read the comment docs.

@dvora-h dvora-h merged commit d3a7a75 into redis:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants