Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jun 2, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

fixes #2209

@dvora-h dvora-h added the bug Bug label Jun 2, 2022
@dvora-h dvora-h requested a review from chayim June 2, 2022 13:54
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #2210 (be0e4e8) into master (a2365d1) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #2210 +/- ## ========================================== - Coverage 91.84% 91.83% -0.02%  ========================================== Files 108 108 Lines 27691 27691 ========================================== - Hits 25433 25429 -4  - Misses 2258 2262 +4 
Impacted Files Coverage Δ
redis/lock.py 100.00% <ø> (ø)
setup.py 0.00% <ø> (ø)
tests/test_asyncio/test_search.py 98.35% <0.00%> (-0.33%) ⬇️
tests/test_cluster.py 96.91% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2365d1...be0e4e8. Read the comment docs.

@dvora-h dvora-h merged commit bedf3c8 into redis:master Jun 2, 2022
@dvora-h dvora-h deleted the fix-lock branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug

3 participants