Skip to content

Conversation

@utkarshgupta137
Copy link
Contributor

@utkarshgupta137 utkarshgupta137 commented May 21, 2022

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?
@utkarshgupta137 utkarshgupta137 force-pushed the async_cluster_typing branch 7 times, most recently from c1c85ec to ca09cb9 Compare May 26, 2022 16:51
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #2195 (ebf2ded) into master (4807908) will increase coverage by 0.01%.
The diff coverage is 97.29%.

@@ Coverage Diff @@ ## master #2195 +/- ## ========================================== + Coverage 91.99% 92.00% +0.01%  ========================================== Files 108 108 Lines 27380 27390 +10 ========================================== + Hits 25189 25201 +12  + Misses 2191 2189 -2 
Impacted Files Coverage Δ
redis/asyncio/cluster.py 89.24% <95.83%> (+0.16%) ⬆️
redis/asyncio/connection.py 83.85% <100.00%> (ø)
redis/asyncio/parser.py 80.00% <100.00%> (ø)
redis/cluster.py 90.34% <100.00%> (+0.01%) ⬆️
redis/utils.py 89.18% <100.00%> (+0.30%) ⬆️
tests/test_asyncio/test_cluster.py 97.60% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 97.14% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4807908...ebf2ded. Read the comment docs.

Copy link
Collaborator

@dvora-h dvora-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always @utkarshgupta137! I just merged in the latest master- it all passes, and we’ll merge this in.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label May 30, 2022
@utkarshgupta137
Copy link
Contributor Author

@dvora-h Your merge commit has removed Any from connection_kwargs in ClusterNode.

@dvora-h
Copy link
Collaborator

dvora-h commented May 30, 2022

Sorry, I fixed that

@dvora-h
Copy link
Collaborator

dvora-h commented May 30, 2022

@utkarshgupta137 Thanks for the quick fix.

@dvora-h dvora-h merged commit f704281 into redis:master May 30, 2022
@utkarshgupta137 utkarshgupta137 deleted the async_cluster_typing branch June 2, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

3 participants