Fix retries in async mode #2180
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of change
The main goal of this PR is to fix retries in asyncio mode. As described on #2179, in asyncio mode, there are currently no retries on other errors than
TimeoutErrorerrors.To fix that bug the PR first makes the way retries are configured consistent in sync and async. It then modifies the
_disconnect_raisefunction not to raise on any "supported error".Note: I think there are other problems with the retry configuration API, but for now I just wanted to fix the actual bug while making the retry configuration API consistent between sync and async.
Fixes #2179.
Pull Request check-list
$ toxpass with this change (including linting)?Is there an example added to the examples folder (if applicable)?