Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented May 2, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2131 closes #2132

@dvora-h dvora-h added feature New feature redis-7 labels May 2, 2022
@dvora-h dvora-h requested a review from chayim May 2, 2022 11:57
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #2161 (3553a2d) into master (40fdb15) will decrease coverage by 0.50%.
The diff coverage is 32.60%.

@@ Coverage Diff @@ ## master #2161 +/- ## ========================================== - Coverage 92.50% 92.00% -0.51%  ========================================== Files 105 105 Lines 25191 25262 +71 ========================================== - Hits 23303 23242 -61  - Misses 1888 2020 +132 
Impacted Files Coverage Δ
tests/test_commands.py 91.48% <11.76%> (-2.20%) ⬇️
redis/commands/core.py 83.33% <31.25%> (-0.53%) ⬇️
redis/client.py 89.04% <54.54%> (-0.43%) ⬇️
tests/test_asyncio/test_commands.py 99.58% <100.00%> (+<0.01%) ⬆️
redis/retry.py 95.83% <0.00%> (-4.17%) ⬇️
redis/asyncio/retry.py 92.30% <0.00%> (-3.85%) ⬇️
tests/test_graph_utils/test_edge.py 94.59% <0.00%> (-2.71%) ⬇️
tests/test_ssl.py 47.51% <0.00%> (-2.13%) ⬇️
redis/asyncio/connection.py 83.21% <0.00%> (-1.63%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fdb15...3553a2d. Read the comment docs.

@dvora-h dvora-h merged commit 5c99e27 into redis:master May 3, 2022
@dvora-h dvora-h deleted the acl branch May 9, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants