Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Apr 27, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2124

@dvora-h dvora-h added feature New feature redis-7 labels Apr 27, 2022
@dvora-h dvora-h requested a review from chayim April 27, 2022 11:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #2147 (f35d35d) into master (6ba4641) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head f35d35d differs from pull request most recent head 2db85a8. Consider uploading reports for the commit 2db85a8 to get more accurate results

@@ Coverage Diff @@ ## master #2147 +/- ## ======================================= Coverage 92.44% 92.44% ======================================= Files 104 104 Lines 24385 24391 +6 ======================================= + Hits 22542 22548 +6  Misses 1843 1843 
Impacted Files Coverage Δ
redis/commands/core.py 83.96% <50.00%> (-0.04%) ⬇️
tests/test_commands.py 94.26% <50.00%> (-0.06%) ⬇️
redis/asyncio/connection.py 84.83% <0.00%> (+0.11%) ⬆️
tests/test_cluster.py 97.48% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba4641...2db85a8. Read the comment docs.

@chayim chayim merged commit 09a52db into redis:master May 2, 2022
@dvora-h dvora-h deleted the latency-histogram branch May 9, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants