Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Apr 27, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2125

@dvora-h dvora-h added feature New feature redis-7 labels Apr 27, 2022
@dvora-h dvora-h requested a review from chayim April 27, 2022 10:57
pieces.append("CONFIG")
pieces.extend(options)
if args is not None:
pieces.append("ARGS")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #2146 (ac13fd6) into master (cb91eed) will decrease coverage by 0.04%.
The diff coverage is 26.31%.

@@ Coverage Diff @@ ## master #2146 +/- ## ========================================== - Coverage 92.45% 92.41% -0.05%  ========================================== Files 104 104 Lines 24364 24404 +40 ========================================== + Hits 22526 22552 +26  - Misses 1838 1852 +14 
Impacted Files Coverage Δ
redis/commands/core.py 83.63% <11.11%> (-0.38%) ⬇️
tests/test_commands.py 94.14% <40.00%> (-0.18%) ⬇️
tests/test_search.py 99.19% <0.00%> (+0.01%) ⬆️
redis/commands/search/field.py 98.57% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb91eed...ac13fd6. Read the comment docs.

@dvora-h dvora-h merged commit 1f046ac into redis:master Apr 27, 2022
@dvora-h dvora-h deleted the module-loadex branch May 9, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants