Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Apr 26, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1947

@dvora-h dvora-h added feature New feature redis-7 labels Apr 26, 2022
@dvora-h dvora-h requested a review from chayim April 26, 2022 13:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #2141 (48514b6) into master (cb91eed) will increase coverage by 0.00%.
The diff coverage is 62.50%.

@@ Coverage Diff @@ ## master #2141 +/- ## ======================================= Coverage 92.45% 92.45% ======================================= Files 104 104 Lines 24364 24393 +29 ======================================= + Hits 22526 22553 +27  - Misses 1838 1840 +2 
Impacted Files Coverage Δ
redis/commands/core.py 83.96% <50.00%> (-0.04%) ⬇️
tests/test_commands.py 94.26% <66.66%> (-0.06%) ⬇️
redis/asyncio/connection.py 84.72% <0.00%> (-0.12%) ⬇️
tests/test_search.py 99.19% <0.00%> (+0.01%) ⬆️
redis/commands/search/field.py 98.57% <0.00%> (+0.08%) ⬆️
tests/conftest.py 87.25% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb91eed...48514b6. Read the comment docs.

@dvora-h dvora-h merged commit 2da2ac3 into redis:master Apr 27, 2022
@dvora-h dvora-h deleted the command-getkeysandflags branch May 9, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants