Skip to content

Conversation

@Andrew-Chen-Wang
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #2088 (e360469) into master (20e4b87) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## master #2088 +/- ## ========================================== - Coverage 91.22% 91.21% -0.02%  ========================================== Files 100 100 Lines 21486 21486 ========================================== - Hits 19601 19598 -3  - Misses 1885 1888 +3 
Impacted Files Coverage Δ
redis/commands/core.py 82.85% <100.00%> (ø)
tests/test_cluster.py 97.48% <0.00%> (-0.12%) ⬇️
redis/asyncio/connection.py 82.75% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e4b87...e360469. Read the comment docs.

@WisdomPill
Copy link
Contributor

WisdomPill commented Apr 18, 2022

@Andrew-Chen-Wang and @chayim could this be merged ASAP? It makes not python 3.10 unhappy 🐍 🙁

I was about to open a PR to fix it 😄

@chayim
Copy link
Contributor

chayim commented Apr 18, 2022

I mean sure, since I literally caught this ;). But you'll need to grab master.

@chayim chayim merged commit e5e265d into redis:master Apr 18, 2022
@WisdomPill
Copy link
Contributor

is there an issue for adding mypy?

@WisdomPill
Copy link
Contributor

thanks for the quick merge... for the master, there is no problem, django-redis uses latest and master, it will be the first time it will pass checks on master but not latest 😂

@Andrew-Chen-Wang Andrew-Chen-Wang deleted the patch-5 branch April 18, 2022 15:11
@Andrew-Chen-Wang
Copy link
Contributor Author

is there an issue for adding mypy?

We're not really concerned about typing at the moment since the async portion is being reimplemented for performance sake and the sync portion of redis-py doesn't have typing yet. Once some of these things get flattened out, then I think mypy can be enabled.

TL;DR just lots of things need to get done first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants