Skip to content

Merging http-random-access and random-access-http #15

@e-e-e

Description

@e-e-e

I am opening this issue to discuss merging our two implementations.

I have not moved https://github.com/e-e-e/http-random-access into the random-access-storage org yet as I knew that this module already existed and it felt silly to have two versions of essentially the same thing. However they are structurally different.

I created http-random-access for use as a drop in replacement for raf and ram in dat storage. random-access-http does not work for this purpose as it requires absolute urls, and throws errors on write. http-random-access also uses axios rather than nodes native http module, so that its browser compatible.

I just updated my implementation to use the latest random-access-storage and while I was at it I made it work with absolute urls too in addition to relative urls. It now also passes your tests in addition to mine. I wanted to suggest that we simply merge my implementation into this repository and do a major version bump, and deprecate http-random-access. Although is there anything in this implementation that is not currently covered by http-random-access? Have I missed anything?

What are your thoughts @bcomnes, @mafintosh, @scriptjs, @juliangruber?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions