Move __name__ mangling to end of module #156
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changing
__name__in the middle of the module causes subsequent definitions to have the mangled (and therefore incorrect)__module__, which causes a bad interaction withcloudpickle(which in turn needs to ensure pickled functions can be imported from their__module__). Moving the__name__change to the end of the module satisfies theDeprecationWarningcheck while sidestepping the above.