Skip to content

Conversation

@mcclymont
Copy link
Contributor

I was surprised to find out that from_time was not a class method, but an instance method.
This limits its usefulness, as to create a new Timestamp you have to first instantiate the object, then call the from_time method, and then you need to return/use the saved instance, because the from_time method returns the self.nanos value, rather than the timestamp itself.

Code example

Before

{ updated_at: Google::Protobuf::Timestamp.new.tap { |t| t.from_time(updated_at) }, }

After

{ updated_at: Google::Protobuf::Timestamp.from_time(updated_at), }
@google-cla
Copy link

google-cla bot commented May 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@TeBoring
Copy link
Contributor

TeBoring commented Jun 1, 2021

@mcclymont, could you sign the cla?

@mcclymont
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 1, 2021
@mcclymont
Copy link
Contributor Author

@TeBoring What's the next step? I don't understand the CI failures

@deannagarcia
Copy link
Member

Sorry for the delay, I'm rerunning tests now and will let you know if there's anything that needs fixed.

@deannagarcia
Copy link
Member

Thanks for the addition, merging now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants