- Notifications
You must be signed in to change notification settings - Fork 16k
Closed as not planned
Closed as not planned
Copy link
Labels
bazelinactiveDenotes the issue/PR has not seen activity in the last 90 days.Denotes the issue/PR has not seen activity in the last 90 days.
Description
The files /BUILD and /protobuf.bzl both load from @rules_python at the top level, which defeats Bazel's lazy fetching of dependencies. This forces projects that depend on Protobuf, but not Python, to need the @rules_python dependency declared.
For /BUILD, I recommend moving the py_library targets into a new file python/BUILD and setting up aliases at the old locations. See PR #7190 for a similar change applied to the Java targets.
For /protobuf.bzl, the py_proto_library() symbol should be moved into an equivalent file under python/. Doing this as a breaking change would be easiest since py_proto_library() is unfortunately a macro, but it may also be possible to replace it with a rule and thereby maintain the existing API.
0x2Adr1
Metadata
Metadata
Assignees
Labels
bazelinactiveDenotes the issue/PR has not seen activity in the last 90 days.Denotes the issue/PR has not seen activity in the last 90 days.