ObjC Proto3 optional support #7421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
FieldDescriptor::has_presence works as a replacement for the custom logic we had for FieldGenerator::WantsHasProperty(), and is already proto3 optional aware.
- Don't make an OneofGenerator for synthetic oneofs. - Update the field calculations that determine if hasbits are needed to know about synthetic oneofs and ignore them.
- Add a Descriptor flag to capture if the field should clear on being zeroed. - Update the runtime to use the new clear on zero flag. - Add a flag on message initialization to indicate the sources were generated with/without this support so the runtime can backfill the flag for older generated sources.
- With the new flags, the syntax isn't needed, so don't pass it. - To keep library binary compatibility, rename the helpers since one "Internal" method was called from generated code. Keep a shim with the old signature to support those generated sources.
- Add/document an public api for clearing oneofs. - Move the current library internals to a new api and keep a shim for old generated code.
- Bump the version marker in the generated code. - Set the flag to say clear on zero is known. - Set clear on zero for proto3 optional fields that aren't tagged as optional. - Also tweak the call from some C generated code to use different apis with better validation. - Mark the ObjC generator as supporting the proto3 optional feature. - Regenerate the WKTs to get the new flags.
Contributor Author
dmaclach requested changes Apr 24, 2020
Contributor
dmaclach left a comment
dmaclach left a comment There was a problem hiding this comment.
Mostly comments about comments :)
dmaclach approved these changes Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.