Fix collectorID calculation for Unregister() #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for the fix of unregister. However, the vec part should stay with fnv64a. See commit description of ee1078a |
| @beorn7 got it. Will revert that part. |
Signed-off-by: Leo Antunes <leo@costela.net>
| Done! ✔️ |
beorn7 approved these changes Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression from 1.2.0 where the calculation of
collectorIDchanged duringRegister(), but not duringUnregister()It also brings the vec code closer to the rest by addopting(reverted, see #663 (comment))xxhasheverywhere.Finally, we also add a simple test case to ensure this doesn't happen again! 😉
fixes #662