Skip to content

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Dec 14, 2021

Part of #3742

This switches cache-utils from CommonJS to pure ES modules.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅
@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Dec 14, 2021
@ehmicky ehmicky self-assigned this Dec 14, 2021
@ehmicky ehmicky changed the title chore: use pure ES modules with cache-utils chore!: use pure ES modules with cache-utils Dec 14, 2021
@ehmicky ehmicky force-pushed the chore/cache-utils-esm branch from 849061f to 4077e53 Compare December 14, 2021 17:51
@@ -1,21 +1,19 @@
'use strict'
Copy link
Contributor Author

@ehmicky ehmicky Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test main files must be .mjs due to ava not working well in monorepos mixing CommonJS and ESM packages. Once all packages of this monorepos are switched to ESM, those files can be renamed to .js.

@ehmicky ehmicky force-pushed the chore/cache-utils-esm branch 4 times, most recently from 4110577 to e87e894 Compare December 15, 2021 17:10
@ehmicky ehmicky force-pushed the chore/cache-utils-esm branch from e87e894 to d667581 Compare December 15, 2021 20:07
@ehmicky ehmicky force-pushed the chore/cache-utils-esm branch from d667581 to 674263e Compare December 15, 2021 20:36
@kodiakhq kodiakhq bot merged commit ca0ac3b into main Dec 15, 2021
@kodiakhq kodiakhq bot deleted the chore/cache-utils-esm branch December 15, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge type: chore work needed to keep the product and development running smoothly

2 participants