Merge pull request #37 from ajdavis/SPEC-244-remember-electionId

Remember electionId

Author: ajdavis

source/server-discovery-and-monitoring/tests/rs/equal_electionids.yml

@@ -28,8 +28,8 @@ phases: [
  servers: {
  "a:27017": {
  type: "Unknown",
- setName:,
- electionId:,
+ setName: ,
+ electionId:
  },
  "b:27017": {
  type: "RSPrimary",

source/server-discovery-and-monitoring/tests/rs/new_primary_new_electionid.yml

@@ -25,7 +25,7 @@ phases: [
  },
  "b:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  }
  },
@@ -50,7 +50,7 @@ phases: [
  servers: {
  "a:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  },
  "b:27017": {
@@ -79,7 +79,7 @@ phases: [
  servers: {
  "a:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  },
  "b:27017": {

source/server-discovery-and-monitoring/tests/rs/null_election_id.json

@@ -1,5 +1,5 @@
 {
- "description": "Primary with no electionId, then a primary with electionId", 
+ "description": "Primaries with and without electionIds", 
  "phases": [
  {
  "outcome": {
@@ -13,6 +13,11 @@
  "electionId": null, 
  "setName": null, 
  "type": "Unknown"
+ }, 
+ "c:27017": {
+ "electionId": null, 
+ "setName": null, 
+ "type": "Unknown"
  }
  }, 
  "setName": "rs", 
@@ -24,7 +29,8 @@
  {
  "hosts": [
  "a:27017", 
- "b:27017"
+ "b:27017", 
+ "c:27017"
  ], 
  "ismaster": true, 
  "ok": 1, 
@@ -43,10 +49,15 @@
  }, 
  "b:27017": {
  "electionId": {
- "$oid": "000000000000000000000001"
+ "$oid": "000000000000000000000002"
  }, 
  "setName": "rs", 
  "type": "RSPrimary"
+ }, 
+ "c:27017": {
+ "electionId": null, 
+ "setName": null, 
+ "type": "Unknown"
  }
  }, 
  "setName": "rs", 
@@ -57,11 +68,12 @@
  "b:27017", 
  {
  "electionId": {
- "$oid": "000000000000000000000001"
+ "$oid": "000000000000000000000002"
  }, 
  "hosts": [
  "a:27017", 
- "b:27017"
+ "b:27017", 
+ "c:27017"
  ], 
  "ismaster": true, 
  "ok": 1, 
@@ -82,6 +94,11 @@
  "electionId": null, 
  "setName": null, 
  "type": "Unknown"
+ }, 
+ "c:27017": {
+ "electionId": null, 
+ "setName": null, 
+ "type": "Unknown"
  }
  }, 
  "setName": "rs", 
@@ -93,7 +110,49 @@
  {
  "hosts": [
  "a:27017", 
- "b:27017"
+ "b:27017", 
+ "c:27017"
+ ], 
+ "ismaster": true, 
+ "ok": 1, 
+ "setName": "rs"
+ }
+ ]
+ ]
+ }, 
+ {
+ "outcome": {
+ "servers": {
+ "a:27017": {
+ "electionId": null, 
+ "setName": "rs", 
+ "type": "RSPrimary"
+ }, 
+ "b:27017": {
+ "electionId": null, 
+ "setName": null, 
+ "type": "Unknown"
+ }, 
+ "c:27017": {
+ "electionId": null, 
+ "setName": null, 
+ "type": "Unknown"
+ }
+ }, 
+ "setName": "rs", 
+ "topologyType": "ReplicaSetWithPrimary"
+ }, 
+ "responses": [
+ [
+ "c:27017", 
+ {
+ "electionId": {
+ "$oid": "000000000000000000000001"
+ }, 
+ "hosts": [
+ "a:27017", 
+ "b:27017", 
+ "c:27017"
  ], 
  "ismaster": true, 
  "ok": 1, 

source/server-discovery-and-monitoring/tests/rs/null_election_id.yml

@@ -1,4 +1,4 @@
-description: "Primary with no electionId, then a primary with electionId"
+description: "Primaries with and without electionIds"
 
 uri: "mongodb://a/?replicaSet=rs"
 
@@ -10,7 +10,7 @@ phases: [
  ["a:27017", {
  ok: 1,
  ismaster: true,
- hosts: ["a:27017", "b:27017"],
+ hosts: ["a:27017", "b:27017", "c:27017"],
  setName: "rs"
  }]
  ],
@@ -24,7 +24,12 @@ phases: [
  },
  "b:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
+ electionId:
+ },
+ "c:27017": {
+ type: "Unknown",
+ setName: ,
  electionId:
  }
  },
@@ -39,23 +44,28 @@ phases: [
  ["b:27017", {
  ok: 1,
  ismaster: true,
- hosts: ["a:27017", "b:27017"],
+ hosts: ["a:27017", "b:27017", "c:27017"],
  setName: "rs",
- electionId: {"$oid": "000000000000000000000001"}
+ electionId: {"$oid": "000000000000000000000002"}
  }]
  ],
 
  outcome: {
  servers: {
  "a:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  },
  "b:27017": {
  type: "RSPrimary",
  setName: "rs",
- electionId: {"$oid": "000000000000000000000001"}
+ electionId: {"$oid": "000000000000000000000002"}
+ },
+ "c:27017": {
+ type: "Unknown",
+ setName: ,
+ electionId:
  }
  },
  topologyType: "ReplicaSetWithPrimary",
@@ -69,7 +79,7 @@ phases: [
  ["a:27017", {
  ok: 1,
  ismaster: true,
- hosts: ["a:27017", "b:27017"],
+ hosts: ["a:27017", "b:27017", "c:27017"],
  setName: "rs"
  }]
  ],
@@ -82,13 +92,53 @@ phases: [
  },
  "b:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
+ electionId:
+ },
+ "c:27017": {
+ type: "Unknown",
+ setName: ,
+ electionId:
+ }
+ },
+ topologyType: "ReplicaSetWithPrimary",
+ setName: "rs",
+ }
+ },
+
+ # But we remember A's electionId, so when we finally hear from C
+ # claiming it is primary, we ignore it due to its outdated electionId
+ {
+ responses: [
+ ["c:27017", {
+ ok: 1,
+ ismaster: true,
+ hosts: ["a:27017", "b:27017", "c:27017"],
+ setName: "rs",
+ electionId: {"$oid": "000000000000000000000001"}
+ }]
+ ],
+ outcome: {
+ servers: {
+ # Still primary.
+ "a:27017": {
+ type: "RSPrimary",
+ setName: "rs",
+ electionId:
+ },
+ "b:27017": {
+ type: "Unknown",
+ setName: ,
+ electionId:
+ },
+ "c:27017": {
+ type: "Unknown",
+ setName: ,
  electionId:
  }
  },
  topologyType: "ReplicaSetWithPrimary",
  setName: "rs",
- # But we remember old electionId.
  }
  }
 ]

source/server-discovery-and-monitoring/tests/rs/primary_disconnect_electionid.yml

@@ -27,7 +27,7 @@ phases: [
  servers: {
  "a:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  },
  "b:27017": {
@@ -50,12 +50,12 @@ phases: [
  servers: {
  "a:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  },
  "b:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  }
  },
@@ -79,12 +79,12 @@ phases: [
  servers: {
  "a:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  },
  "b:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  }
  },
@@ -113,7 +113,7 @@ phases: [
  },
  "b:27017": {
  type: "Unknown",
- setName:,
+ setName: ,
  electionId:
  }
  },