Skip to content

fix(NODE-5296): construct error messages for AggregateErrors in Node16+ #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 25, 2023
Merged

fix(NODE-5296): construct error messages for AggregateErrors in Node16+ #3682

merged 6 commits into from
May 25, 2023

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented May 23, 2023

Description

What is changing?

MongoErrors now appropriately handle AggregateErrors and construct a message from the error messages of each sub-error.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket
baileympearson
baileympearson commented May 23, 2023
View reviewed changes
@nbbeeken nbbeeken self-requested a review May 24, 2023 15:50
@nbbeeken nbbeeken self-assigned this May 24, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 24, 2023
nbbeeken
nbbeeken suggested changes May 24, 2023
View reviewed changes
@baileympearson baileympearson requested a review from nbbeeken May 24, 2023 17:55
nbbeeken
nbbeeken suggested changes May 24, 2023
View reviewed changes
nbbeeken
nbbeeken suggested changes May 24, 2023
View reviewed changes
@baileympearson baileympearson requested a review from nbbeeken May 24, 2023 20:30
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 24, 2023
@baileympearson baileympearson mentioned this pull request May 24, 2023
Merged
5 tasks
nbbeeken
nbbeeken suggested changes May 25, 2023
View reviewed changes
@nbbeeken nbbeeken merged commit e03178e into main May 25, 2023
@nbbeeken nbbeeken deleted the NODE-5296-aggregate-error-5.x branch May 25, 2023 16:59
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

3 participants

@baileympearson @nbbeeken