Skip to content

feat(NODE-4795): deprecate addUser helper #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2023
Merged

feat(NODE-4795): deprecate addUser helper #3624

merged 4 commits into from
Apr 6, 2023

Conversation

@durran
Copy link
Member

@durran durran commented Apr 4, 2023

Description

Deprecates the addUser helper.

What is changing?

  • Deprecates the addUser helper along with the associated options.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4795

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket
@W-A-James W-A-James self-requested a review April 4, 2023 13:50
@W-A-James W-A-James self-assigned this Apr 4, 2023
W-A-James
W-A-James suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to deprecate the db#addUser helper method
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 4, 2023
@durran
Copy link
Member Author

durran commented Apr 5, 2023

We also need to deprecate the db#addUser helper method

Done.
@durran durran requested a review from W-A-James April 5, 2023 08:37
W-A-James
W-A-James previously approved these changes Apr 5, 2023
View reviewed changes
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 5, 2023
nbbeeken
nbbeeken suggested changes Apr 5, 2023
View reviewed changes
@durran durran requested a review from nbbeeken April 6, 2023 09:02
@W-A-James W-A-James self-requested a review April 6, 2023 17:54
@W-A-James W-A-James merged commit 53a0aae into main Apr 6, 2023
@W-A-James W-A-James deleted the NODE-4795 branch April 6, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

4 participants

@durran @nbbeeken @W-A-James