Issue 291 - Changed parse path function considering nested query parameters.

[nikithauc]

URL parsing failed because the parsePath() function did not considering nested query functions. Changed the function to split the query parameters on the first equals sign( OData Parsing rules).

Also, added comments to few query option functions mentioning their expected behaviour.

[ghost]

All CLA requirements met.

[jobala]

These changes work for me, except for the edge case pointed by @zengin.

I have a few suggestions regarding improving the code's readability.

1. We can improve readability of the if block by using variable names instead of expressions.

const hasOdataQueryName = oDataQueryNames.indexOf(paramKey) !== -1; if (hasOdataQueryName) { ... } 

2. By extracting smaller functions from query() ie handleQueryString() & handleQueryDictionary we make it easy to see what the function is doing.

What do you think of extracting the changes added to query() in a separate function then call the extracted function in parsePath() and query()?

[ddyett]

shouldn't there be a break here? if not can you add a comment about the intent of the code here. once paramKey is set it's not clear why continue

[nikithauc]

It was a mistake on my part. Corrected the code so that the iteration records key and value for each parameter in the dictionary.

[ddyett]

can you comment here on what the modification the graphrequest is. It currently reads like I passed in something and got the same thing back.

[nikithauc]

Added more information in some comments. There are more comments like this one. Will change them in another PR.

[nikithauc]

These changes work for me, except for the edge case pointed by @zengin.

I have a few suggestions regarding improving the code's readability.

1. We can improve readability of the if block by using variable names instead of expressions.

const hasOdataQueryName = oDataQueryNames.indexOf(paramKey) !== -1; if (hasOdataQueryName) { ... } 

1. By extracting smaller functions from query() ie handleQueryString() & handleQueryDictionary we make it easy to see what the function is doing.

What do you think of extracting the changes added to query() in a separate function then call the extracted function in parsePath() and query()?

I have added a private function which is called by parsePath() and query() function. I have tried using variables in place of expressions wherever the expression appears more than once. And tried breaking down to small functions.

[zengin]

Thanks for taking a test centric approach for this fix.