loader: Enforce version equality in slot deps #2488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In case of slotted dependency, interpret the version as a strict requirement, not just as a minimum compatible version. This change fixes a problem of incorrect dependency resolution for fully dependent slots (a,s0 -> b,s0 and b,s0 -> a,s0), because the satisfaction of both of them will be checked in an image with lower index, which is required for the current algorithm to work correctly. Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
Collaborator Author
| Decided to fix the issue by removing the slotted dependency feature. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In case of slotted dependency, interpret the version as a strict requirement, not just as a minimum compatible version.
This change fixes a problem of incorrect dependency resolution for fully dependent slots (a,s0 -> b,s0 and b,s0 -> a,s0), because the satisfaction of both of them will be checked in an image with lower index, which is required for the current algorithm to work correctly.