[4.x] Remove Unreachable return in PHPUnit test stubs #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
$this->markTestSkipped()is used in many PHPUnit tests to skip testing disabled features, and throws an exception to immediately end the test. However, there is also an unreachablereturnstatement after every call tomarkTestSkipped. This causes static analysis tools like PHPStan that are looking for dead code to trigger on the tests until someone cleans them up. Since they are functionally irrelevant, it'd be nice to clean up the stubs and drop thereturnstatements.