Merge pull request microsoft#7711 from YuichiNukiyama/fix4957

Throw error when tsconfig.json has excludes without exclude property

Author: mhegazy

src/compiler/commandLineParser.ts

@@ -667,6 +667,9 @@ namespace ts {
  }
  }
  }
+ if (hasProperty(json, "excludes") && !hasProperty(json, "exclude")) {
+ errors.push(createCompilerDiagnostic(Diagnostics.Unknown_option_excludes_Did_you_mean_exclude));
+ }
  return fileNames;
  }
  }

src/compiler/diagnosticMessages.json

@@ -2620,6 +2620,10 @@
  "category": "Message",
  "code": 6113
  },
+ "Unknown option 'excludes'. Did you mean 'exclude'?": {
+ "category": "Error",
+ "code": 6114
+ },
 
  "Variable '{0}' implicitly has an '{1}' type.": {
  "category": "Error",

tests/cases/unittests/tsconfigParsing.ts

@@ -13,6 +13,12 @@ namespace ts {
  assert.isTrue(undefined === parsed.config);
  assert.isTrue(undefined !== parsed.error);
  }
+ 
+ function assertParseErrorWithExcludesKeyword(jsonText: string) {
+ let parsed = ts.parseConfigFileTextToJson("/apath/tsconfig.json", jsonText);
+ let parsedCommand = ts.parseJsonConfigFileContent(parsed, ts.sys, "tests/cases/unittests");
+ assert.isTrue(undefined !== parsedCommand.errors);
+ }
 
  it("returns empty config for file with only whitespaces", () => {
  assertParseResult("", { config : {} });
@@ -102,5 +108,17 @@ namespace ts {
  config: { compilerOptions: { lib: "es5,es6" } }
  });
  });
+ 
+ it("returns error when tsconfig have excludes", () => {
+ assertParseErrorWithExcludesKeyword(
+ `{
+ "compilerOptions": {
+ "lib": "es5"
+ },
+ "excludes": [
+ "foge.ts"
+ ]
+ }`);
+ });
  });
 }