Skip to content

Commit 6d98902

Browse files
committed
Merge pull request bbatsov#26 from uvtc/patch-3
`if` is for getting a value, not nec. side-effecty
2 parents 607f004 + f834535 commit 6d98902

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -216,14 +216,14 @@ You can generate a PDF or an HTML copy of this guide using
216216
```Clojure
217217
;; good
218218
(if-let [result :foo]
219-
(do-something-with result)
220-
(do-something-else))
219+
(something-with result)
220+
(something-else))
221221

222222
;; bad
223223
(let [result :foo]
224224
(if result
225-
(do-something-with result)
226-
(do-something-else)))
225+
(something-with result)
226+
(something-else)))
227227
```
228228

229229
* Use `when-let` instead of `let` + `when`.
@@ -232,13 +232,13 @@ You can generate a PDF or an HTML copy of this guide using
232232
;; good
233233
(when-let [result :foo]
234234
(do-something-with result)
235-
(do-something-else-with result))
235+
(do-something-more-with result))
236236

237237
;; bad
238238
(let [result :foo]
239239
(when result
240240
(do-something-with result)
241-
(do-something-else-with result)))
241+
(do-something-more-with result)))
242242
```
243243

244244
* Use `if-not` instead of `(if (not ...) ...)`.

0 commit comments

Comments
 (0)