fix: work around broken console methods

Sometimes console methods are broken, but this shouldn't break tests. See angular/angular.js#16644 (comment)

Author: thorn0

context/karma.js

@@ -122,7 +122,11 @@ function ContextKarma (callParentKarmaMethod) {
  }
  localConsole[method] = function () {
  self.log(method, arguments)
- return Function.prototype.apply.call(orig, localConsole, arguments)
+ try {
+ return Function.prototype.apply.call(orig, localConsole, arguments)
+ } catch (error) {
+ self.log('warn', ['Console method ' + method + ' threw: ' + error])
+ }
  }
  }
  for (var i = 0; i < logMethods.length; i++) {

test/client/karma.spec.js

@@ -289,6 +289,57 @@ describe('Karma', function () {
  assert.equal(promptCalled, true)
  assert.equal(promptResult, 'user-input')
  })
+
+ it('should patch the console if captureConsole is true', function () {
+ sinon.spy(ck, 'log')
+ ck.config.captureConsole = true
+
+ var mockWindow = {
+ console: {
+ log: function () {}
+ }
+ }
+
+ ck.setupContext(mockWindow)
+ mockWindow.console.log('What?')
+ assert(ck.log.calledWith('log'))
+ assert(ck.log.args[0][1][0] === 'What?')
+ })
+
+ it('should not patch the console if captureConsole is false', function () {
+ sinon.spy(ck, 'log')
+ ck.config.captureConsole = false
+
+ var mockWindow = {
+ console: {
+ log: function () {}
+ }
+ }
+
+ ck.setupContext(mockWindow)
+ mockWindow.console.log('hello')
+ assert(!ck.log.called)
+ })
+
+ it('should not allow broken console methods to break tests (if captureConsole is true)', function () {
+ sinon.spy(ck, 'log')
+ ck.config.captureConsole = true
+
+ var mockWindow = {
+ console: {
+ log: function () {
+ throw new Error('I am a broken console.log method.')
+ }
+ }
+ }
+
+ ck.setupContext(mockWindow)
+ mockWindow.console.log('What?')
+ assert(ck.log.calledWith('log'))
+ assert.equal(ck.log.args[0][1][0], 'What?')
+ assert(ck.log.calledWith('warn'))
+ assert(/^Console method log threw:[\s\S]+I am a broken console\.log method/.test(ck.log.args[1][1][0]))
+ })
  })
 
  describe('complete', function () {
@@ -343,37 +394,6 @@ describe('Karma', function () {
  clock.tick(10)
  })
 
- it('should patch the console if captureConsole is true', function () {
- sinon.spy(ck, 'log')
- ck.config.captureConsole = true
-
- var mockWindow = {
- console: {
- log: function () {}
- }
- }
-
- ck.setupContext(mockWindow)
- mockWindow.console.log('What?')
- assert(ck.log.calledWith('log'))
- assert(ck.log.args[0][1][0] === 'What?')
- })
-
- it('should not patch the console if captureConsole is false', function () {
- sinon.spy(ck, 'log')
- ck.config.captureConsole = false
-
- var mockWindow = {
- console: {
- log: function () {}
- }
- }
-
- ck.setupContext(mockWindow)
- mockWindow.console.log('hello')
- assert(!ck.log.called)
- })
-
  it('should clear context window upon complete when clearContext config is true', function () {
  var config = ck.config = {
  clearContext: true