Skip to content

Conversation

@bmish
Copy link
Contributor

@bmish bmish commented Oct 24, 2021

For module files (which import statements instead of require), we might as well use export statements instead of module.exports to adopt fully modern syntax.

As suggested in: #818 (comment)

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #819 (146b6be) into master (d4a57d8) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 146b6be differs from pull request most recent head df34872. Consider uploading reports for the commit df34872 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## master #819 +/- ## ========================================== - Coverage 99.24% 99.22% -0.02%  ========================================== Files 98 98 Lines 1453 1417 -36 Branches 477 477 ========================================== - Hits 1442 1406 -36  Misses 11 11 
Impacted Files Coverage Δ
src/rules/accessible-emoji.js 100.00% <ø> (ø)
src/rules/alt-text.js 100.00% <ø> (ø)
src/rules/anchor-has-content.js 100.00% <ø> (ø)
src/rules/anchor-is-valid.js 100.00% <ø> (ø)
src/rules/aria-activedescendant-has-tabindex.js 100.00% <ø> (ø)
src/rules/aria-props.js 100.00% <ø> (ø)
src/rules/aria-proptypes.js 93.22% <ø> (-0.12%) ⬇️
src/rules/aria-role.js 100.00% <ø> (ø)
src/rules/aria-unsupported-elements.js 100.00% <ø> (ø)
src/rules/autocomplete-valid.js 100.00% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff26b82...df34872. Read the comment docs.

@bmish
Copy link
Contributor Author

bmish commented Oct 24, 2021

Not so sure how this change could reduce code coverage. Maybe a flake?

@ljharb ljharb force-pushed the export-default branch 3 times, most recently from a3008d3 to df34872 Compare October 26, 2021 22:01
@ljharb ljharb merged commit df34872 into jsx-eslint:master Oct 28, 2021
@ljharb
Copy link
Member

ljharb commented Nov 10, 2021

@bmish turns out this caused #824 - iow, it caused the built files to export { default: rule } instead of rule directly.

ljharb added a commit that referenced this pull request Nov 10, 2021
@bmish
Copy link
Contributor Author

bmish commented Nov 10, 2021

@ljharb thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants