-
- Notifications
You must be signed in to change notification settings - Fork 641
Switch to export default syntax for exporting rules #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #819 +/- ## ========================================== - Coverage 99.24% 99.22% -0.02% ========================================== Files 98 98 Lines 1453 1417 -36 Branches 477 477 ========================================== - Hits 1442 1406 -36 Misses 11 11
Continue to review full report at Codecov.
|
| Not so sure how this change could reduce code coverage. Maybe a flake? |
a3008d3 to df34872 Compare | @ljharb thanks for fixing it! |
For module files (which
importstatements instead ofrequire), we might as well useexportstatements instead ofmodule.exportsto adopt fully modern syntax.As suggested in: #818 (comment)