[New] label-has-associated-control: Add glob support #749
Conversation
| It looks like the build is failing for older version of node 😦 I looked at |
| I switched to using |
ljharb left a comment
ljharb left a comment There was a problem hiding this comment.
Seems good overall, just a few comments.
| `labelComponents` is a list of custom React Component names that should be checked for an associated control. | ||
| `labelAttributes` is a list of attributes to check on the label component and its children for a label. Use this if you have a custom component that uses a string passed on a prop to render an HTML `label`, for example. | ||
| `controlComponents` is a list of custom React Components names that will output an input element. | ||
| `controlComponents` is a list of custom React Components names that will output an input element. Glob format is also supported for names. |
There was a problem hiding this comment.
let's add some examples, or a link to what "glob format" means.
ljharb changed the title label-has-associated-control: Add glob support 
| Seems really close but for a few nits. |
| @ljharb I incorporated the requested changes and add documentation / examples for glob format. Sorry about the long turn around time on this, life got a little hectic the past few weeks. |
No need to apologize! This is open source; we're all volunteering our time. Thank you for circling back to this one! |
| @ljharb good to go? |
ljharb force-pushed the zhall1-add-glob-support-to-label-has-associated-control branch from 64c6eb0 to 7d5511d Compare ljharb left a comment
ljharb left a comment There was a problem hiding this comment.
Also sorry for the delay on my end :-)
3 participants
Description
Add glob support for label-has-associated-control rule. This will allow consumers of this library to have some more powerful matching capabilities when using the
controlComponentsoption.To accomplish this, I brought in the
minimatchlibrary => https://github.com/isaacs/minimatchThere are tons of other libraries to do this same thing. It shouldn't be too hard to switch to any of the others if preferred or a lightweight implementation could be done to support the bare minimum.
This addresses issue #720.
Testing
npm inpm run test