Skip to content

Conversation

@hallzac2
Copy link
Contributor

@hallzac2 hallzac2 commented Oct 5, 2020

Description

Update the recommended config to allow fieldset to have the radiogroup role. Also update the test for this rule to have an entry for this change and one for the presentation role.

MDN lists both radiogroup and presentation as valid options for the role attribute on a fieldset.

This fixes #743.

Testing

  1. Pull this branch (or apply these changes as a patch)
  2. Run npm i
  3. Run npm run test, no tests should fail
@hallzac2
Copy link
Contributor Author

hallzac2 commented Oct 5, 2020

I only added this to the recommended config for now. Is this something that should be added to the strict config as well?

@ljharb ljharb requested a review from jessebeach October 6, 2020 05:33
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #746 (a18f6b0) into master (6b9e89f) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a18f6b0 differs from pull request most recent head d927625. Consider uploading reports for the commit d927625 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## master #746 +/- ## ========================================== - Coverage 99.24% 99.24% -0.01%  ========================================== Files 98 98 Lines 1453 1452 -1 Branches 477 477 ========================================== - Hits 1442 1441 -1  Misses 11 11 
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)
src/util/hasAccessibleChild.js 100.00% <0.00%> (ø)
src/rules/interactive-supports-focus.js 97.05% <0.00%> (ø)
__tests__/__util__/ruleOptionsMapperFactory.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9e89f...d927625. Read the comment docs.

Copy link
Collaborator

@jessebeach jessebeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the PR!

@jessebeach jessebeach force-pushed the allow-fieldset-to-have-role-of-radiogroup branch from a18f6b0 to d927625 Compare April 7, 2021 00:03
@jessebeach jessebeach merged commit 9eea790 into jsx-eslint:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants