-
- Notifications
You must be signed in to change notification settings - Fork 641
Update recommended config to allow fieldset to have the radiogroup role #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update recommended config to allow fieldset to have the radiogroup role #746
Conversation
| I only added this to the |
Codecov Report
@@ Coverage Diff @@ ## master #746 +/- ## ========================================== - Coverage 99.24% 99.24% -0.01% ========================================== Files 98 98 Lines 1453 1452 -1 Branches 477 477 ========================================== - Hits 1442 1441 -1 Misses 11 11
Continue to review full report at Codecov.
|
jessebeach left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the PR!
a18f6b0 to d927625 Compare
Description
Update the recommended config to allow
fieldsetto have theradiogrouprole. Also update the test for this rule to have an entry for this change and one for thepresentationrole.MDN lists both
radiogroupandpresentationas valid options for the role attribute on afieldset.This fixes #743.
Testing
npm inpm run test, no tests should fail