Skip to content

Conversation

@chrisblossom
Copy link
Contributor

If this is expected behavior, I'd suggest removing the autofix when mockImplementation is empty because it can (and did in my case) break people's code.

Fixes: #389

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit d9a79b2 into jest-community:master Aug 12, 2019
@chrisblossom chrisblossom deleted the prefer-spy-on-empty branch August 12, 2019 23:28
@SimenB
Copy link
Member

SimenB commented Aug 12, 2019

When this releases, it'll include a bunch of TS migration stuff. 🤞 nothing breaks as I'm heading to bed 😛

@SimenB
Copy link
Member

SimenB commented Aug 12, 2019

🎉 This PR is included in version 22.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants