Fix bug in rssv2 parser for channel image parsing

Author: jameslawler

package.json

@@ -1,6 +1,6 @@
 {
  "name": "react-native-rss-parser",
- "version": "1.0.0",
+ "version": "1.0.1",
  "description": "React Native compatible package to parse RSS feeds",
  "main": "index.js",
  "scripts": {

parsers/rssv2.js

@@ -90,12 +90,26 @@ function getChannelCategories(node) {
 }
 
 function getChannelImage(node) {
+ const imageNodes = utils.getChildElements(node, 'image');
+
+ if (imageNodes.length === 0) {
+ return {
+ url: undefined,
+ title: undefined,
+ description: undefined,
+ width: undefined,
+ height: undefined
+ };
+ }
+
+ const imageNode = imageNodes[0];
+
  return {
- url: utils.getElementAttributeContent(node, 'image', 'url'),
- title: utils.getElementAttributeContent(node, 'image', 'title'),
- description: utils.getElementAttributeContent(node, 'image', 'description'),
- width: utils.getElementAttributeContent(node, 'image', 'width'),
- height: utils.getElementAttributeContent(node, 'image', 'height'),
+ url: utils.getElementTextContent(imageNode, 'url'),
+ title: utils.getElementTextContent(imageNode, 'title'),
+ description: utils.getElementTextContent(imageNode, 'description'),
+ width: utils.getElementTextContent(imageNode, 'width'),
+ height: utils.getElementTextContent(imageNode, 'height'),
  };
 }
 

test/samples/reuters.js

@@ -11,10 +11,20 @@ describe('when parse reuters', function() {
  assert.equal(result.links.length, 1);
  assert.equal(result.links[0].url, 'http://www.reuters.com');
  assert.equal(result.description, 'Reuters.com is your source for breaking news, business, financial and investing news, including personal finance and stocks. Reuters is the leading global provider of news, financial information and technology solutions to the world\'s media, financial institutions, businesses and individuals.');
+ assert.equal(result.image.url, 'http://www.reuters.com/resources_v2/images/reuters125.png');
+ assert.equal(result.image.title, 'Reuters News');
+ assert.equal(result.image.width, '120');
+ assert.equal(result.image.height, '35');
+ assert.equal(result.language, 'en-us');
+ assert.equal(result.lastUpdated, 'Tue, 30 Jan 2018 17:54:13 -0500');
+ assert.equal(result.copyright, 'All rights reserved. Users may download and print extracts of content from this website for their own personal and non-commercial use only. Republication or redistribution of Reuters content, including by framing or similar means, is expressly prohibited without the prior written consent of Reuters. Reuters and the Reuters sphere logo are registered trademarks or trademarks of the Reuters group of companies around the world. © Reuters 2018');
  assert.equal(result.items.length, 10);
  assert.equal(result.items[0].title, 'U.S. general says North Korea not demonstrated all components of ICBM');
  assert.equal(result.items[0].categories.length, 1);
  assert.equal(result.items[0].categories[0].name, 'worldNews');
+ assert.equal(result.items[1].title, 'Publication of Russia \'oligarch list\' may affect investors: group');
+ assert.equal(result.items[1].categories.length, 1);
+ assert.equal(result.items[1].categories[0].name, 'worldNews');
  });
  });
  });

test/samples/rssv2.js

@@ -21,7 +21,8 @@ describe('when rss parse', function() {
  assert.equal(result.lastPublished, undefined);
  assert.equal(result.categories.length, 1);
  assert.equal(result.categories[0].name, '1765');
- assert.equal(result.image.url, "http://www.example.com/image.jpg");
+ assert.equal(result.image.url, 'http://www.example.com/image.jpg');
+ assert.equal(result.image.title, 'test image');
  assert.equal(result.authors.length, 1);
  assert.equal(result.authors[0].name, 'dave@userland.com');
  assert.equal(result.items.length, 9);