xds: fix ring-hash-picker behaviour #9085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ejona86 approved these changes Apr 18, 2022
YifeiZhuang added the TODO:backport YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Apr 20, 2022
YifeiZhuang removed the TODO:backport YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Apr 25, 2022
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Apr 25, 2022
YifeiZhuang added a commit that referenced this pull request Apr 25, 2022
ringHashPicker changes per gRFC: grpc/grpc#29332: previously it appears the picker logic is wrong, e.g. not request connecting on the any subchannel if it is in TRANSIENT_FAILURE Refactored the logic to mirror the pseudo-code more so easier to understand.
YifeiZhuang added a commit that referenced this pull request Apr 25, 2022
ringHashPicker changes per gRFC: grpc/grpc#29332: previously it appears the picker logic is wrong, e.g. not request connecting on the any subchannel if it is in TRANSIENT_FAILURE Refactored the logic to mirror the pseudo-code more so easier to understand.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ringHashPicker changes per gRFC: grpc/grpc#29332:
previously it appears the picker logic is wrong, e.g. not request connecting on the any subchannel if it is in
TRANSIENT_FAILURERefactored the logic to mirror the pseudo-code more so easier to understand.
stacking on: #9084