core: Add missing setListener if decompressor is unknown #6864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously AbstractServerStream would throw an exception which would kill the RPC with a RST_STREAM. Now the server actually responds with a clean error message and avoids spamming the logs. WARNING: Exception in onHeadersRead() java.lang.IllegalStateException at com.google.common.base.Preconditions.checkState(Preconditions.java:495) at io.grpc.internal.AbstractStream$TransportState.onStreamAllocated(AbstractStream.java:232) at io.grpc.internal.AbstractServerStream$TransportState.onStreamAllocated(AbstractServerStream.java:224) at io.grpc.netty.NettyServerHandler.onHeadersRead(NettyServerHandler.java:451) at io.grpc.netty.NettyServerHandler.access$900(NettyServerHandler.java:101) at io.grpc.netty.NettyServerHandler$FrameListener.onHeadersRead(NettyServerHandler.java:807) at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener.onHeadersRead(DefaultHttp2ConnectionDecoder.java:373)
voidzcy approved these changes Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously AbstractServerStream would throw an exception which would kill the
RPC with a RST_STREAM. Now the server actually responds with a clean error
message and avoids spamming the logs.