fix server panic sending to closed stream #1111 #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
edrex changed the title 
menghanl approved these changes May 15, 2017
Contributor
menghanl left a comment
menghanl left a comment There was a problem hiding this comment.
Looks good. Thanks for the fix.
Contributor
| Though this PR doesn't fix the root problem, it changes the failure from half the time to a race condition. Given that we don't have enough time to look into this issue, I'm going to merge this change. Please send another PR if you think that can fix the root cause. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed fix for #1111. I've already signed the CLA for another Google project (Camlistore).
I'm not aware of a golang construct which can completely guarantee the out chan won't be written to after the closed chan is closed but a nested select like this makes the window when that can happen way smaller. Specifically this change fixes the panic in #1111. Suggestions for improvements?