fix: owlbot-cli image sha to be locked (hermetic) #2252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JoeWang1127 reviewed Nov 24, 2023
JoeWang1127 approved these changes Nov 24, 2023
| [gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!
|
| [java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!
|
blakeli0 approved these changes Nov 28, 2023
Contributor
blakeli0 left a comment
blakeli0 left a comment There was a problem hiding this comment.
LGTM. Let's follow up with a separate PR that use renovate-bot to automatically update the sha.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
owlbot-cli currently defaults to
latest, which is not hermetic. This PR proposes using a configuration file to lock the image to a specific SHA (the SHA cannot be inferred from configuration files in target repositories).As of November 2023, the copy-code command implementation has had 6 commits this year.