Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Nov 10, 2023

Follow up of googleapis/google-cloud-java#10050

  • Confirms java files have been transferred by owl-bot-copy
  • Adds google/iam/v2 in the integration test list.
  • google/iam/v1 is blacklisted from postprocessing list because it is not listed in its owlbot yaml
@diegomarquezp diegomarquezp requested a review from a team as a code owner November 10, 2023 18:43
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 10, 2023
# google/example/library/v1 google-cloud-example-library-v1-java null false
google/devtools/containeranalysis/v1 java-containeranalysis false
google/iam/v1 java-iam false
google/iam/v2 java-iam false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add another line for google/iam/v2 because I use google/iam/v1 to test proto-only library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll disable v1 for the post-processing IT and add v2 separately. The iam owlbot yaml only supports v2 and v2beta1 so using v1 will fail to move any java files into the workspace

@googleapis googleapis deleted a comment from sonarqubecloud bot Nov 10, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 10, 2023

echo "Generate library finished."
echo "Compare generation result..."
if [ $enable_postprocessing == "true" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "${enable_postprocessing}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I added this and a couple other format fixes

@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diegomarquezp diegomarquezp merged commit 94d1dd2 into main Nov 10, 2023
@diegomarquezp diegomarquezp deleted the owlbot-copy-fix-ii branch November 10, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

4 participants